Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormControl asyncValidator not Correctly Overriden #44

Closed
jonrwads opened this issue Sep 8, 2020 · 2 comments · Fixed by #46
Closed

FormControl asyncValidator not Correctly Overriden #44

jonrwads opened this issue Sep 8, 2020 · 2 comments · Fixed by #46

Comments

@jonrwads
Copy link

jonrwads commented Sep 8, 2020

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

Trying to upgrade to Angular 10 and on build I get this error
ERROR in node_modules/@ngneat/reactive-forms/lib/formControl.d.ts:7:14 - error TS2610: 'asyncValidator' is defined as an accessor in class 'FormControl', but is overridden here in 'FormControl<T, E>' as an instance property.

Expected behavior

I would expect it to build without the error above

Minimal reproduction of the problem with instructions

After upgrading to Angular 10, simply try to run the app.

Environment


Angular version: 10.1.0

Others

This was asked in a different issue and I was told it was unrelated so I thought to open up a new issue for any incoming PRs. I have not had the opportunity to dive too deply in this but I am wondering if the asyncValidator needs to be in the FormControl class or if it could just use the inherited property.

Thanks again for your quick response on the original question.

@NetanelBasal
Copy link
Member

Do you want to create a PR?

@jonrwads
Copy link
Author

Just barely got back to this and noticed you had resolved this. Thank you for your quick resolution. I wasn't around this last week to contribute this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants