-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 - Fully Typed Version [BREAKING_CHANGES] #23
Labels
enhancement
New feature or request
Comments
Yes, I just faced problem with it today while migrating an app from Angular Reactive Forms to this lib. Sample of the problem: Component: this.formGroup = this.formBuilder.group<User>({
address: this.formBuilder.group<Address>({
street: '',
city: ''
})
}); HTML: <!-- The same happens if you use `getControl` or `.controls.` as both return `AbstractControl`,
which it isn't accepted by `formGroup` `@Input`. -->
<app-custom-component
[formGroup]="formGroup.get('address')"
></app-custom-component>
To make it work under strict we have to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the current version, we tried to provide the maximum typing functionality we could get to make the migration as seamless as possible.
In the next version, we want to add the following features:
get
orgetControl
we need to infer the control type explicitly:We need to use TS to automatically infer the type so that users can write:
value
anderrors
type:The text was updated successfully, but these errors were encountered: