-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Validators throwing TypeError #22
Comments
I feel like we might need something similar to this, except with Partial instead of Readonly |
@NetanelBasal I'm coming up blank on how to fix it. My best suggestion right now is to potentially advice users of this scenario. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From short initial investigation it seems like this typing:
reactive-forms/projects/ngneat/reactive-forms/src/lib/types.ts
Line 22 in d57c2d8
Needs to be changed to be recursive in such a way that it can aggregate the different Validators that are used on a
FormControl
At the moment, an error is thrown for the following:
email: new FormControl('', [Validators.required, Validators.email])
Which states that
{email: true}
is not assignable to{required: true}
.I believe this needs a slight change to how the object type is built.
The text was updated successfully, but these errors were encountered: