Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RxJS v7 #126

Closed
wSedlacek opened this issue Nov 27, 2021 · 1 comment
Closed

Support RxJS v7 #126

wSedlacek opened this issue Nov 27, 2021 · 1 comment

Comments

@wSedlacek
Copy link

Description

RxJS 6 and 7 is supported by Angular 13

Proposed solution

  • Change RxJS dependency to be '^6.0.0 || ^7.0.0`
  • Update any removed APIs with ones that are compatible with v6
  • Do not use any new ^7.0.0 APIs until Angular has dropped support for RxJS 6 altogether

Alternatives considered

Update to only support ^7.0.0 which would allow usage of the new APIs at the cost of having support misaligned with Angular

Do you want to create a pull request?

Yes

@wSedlacek
Copy link
Author

wSedlacek commented Nov 27, 2021

🤔 After looking at the code it seems that rxjs is not intended to be a dependency of reactive-forms at all.

When I build the package with nx build reactive-forms I get the follow peer dependencies.

  "peerDependencies": {
    "@angular/forms": ">= 13.0.0",
    "@angular/core": "13.0.2"
  },

However when I install the package from npm it has the following dependencies.

  "peerDependencies": {
    "@angular/forms": ">= 13.0.0",
    "rxjs": "~6.6.0",
    "@angular/core": "13.0.2"
  },

This is interesting because the only commit since the 4.0.0 commit was
3adcf11

Perhaps this is an issue of an outdated nx CLI being used to build and publish?
Or perhaps there is some dependency cache going on the CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant