You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Firstly thanks for this great library. It's delightful!
Currently the "opts" parameter of setEnable and setDisable methods of all controls are typed as opts?: Parameters<AbstractControl['disable']> which is a tuple of all parameters of the "disable" method while the intention (of course) is to get the first parameter which would be opts?: Parameters<AbstractControl['disable']>[0].
Is this a regression?
Yes
Description
Firstly thanks for this great library. It's delightful!
Currently the "opts" parameter of setEnable and setDisable methods of all controls are typed as
opts?: Parameters<AbstractControl['disable']>
which is a tuple of all parameters of the "disable" method while the intention (of course) is to get the first parameter which would beopts?: Parameters<AbstractControl['disable']>[0]
.See this line for example: https://github.com/ngneat/reactive-forms/blob/master/libs/reactive-forms/src/lib/form-group.ts#L160
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in
No response
Anything else?
No response
Do you want to create a pull request?
Yes
The text was updated successfully, but these errors were encountered: