Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect types for parameter "opts" of setEnabled and setDisabled #115

Closed
salmoro opened this issue Oct 27, 2021 · 1 comment
Closed

Incorrect types for parameter "opts" of setEnabled and setDisabled #115

salmoro opened this issue Oct 27, 2021 · 1 comment

Comments

@salmoro
Copy link

salmoro commented Oct 27, 2021

Is this a regression?

Yes

Description

Firstly thanks for this great library. It's delightful!

Currently the "opts" parameter of setEnable and setDisable methods of all controls are typed as opts?: Parameters<AbstractControl['disable']> which is a tuple of all parameters of the "disable" method while the intention (of course) is to get the first parameter which would be opts?: Parameters<AbstractControl['disable']>[0].

See this line for example: https://github.com/ngneat/reactive-forms/blob/master/libs/reactive-forms/src/lib/form-group.ts#L160

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in

No response

Anything else?

No response

Do you want to create a pull request?

Yes

@NetanelBasal
Copy link
Member

Sure. You can create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants