feat: add option to show errors always on change #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,11 @@ export type ErrorTailorConfig = { | |||
| blurPredicate?: (element: Element) => boolean; | |||
| controlErrorComponent?: Type<ControlErrorComponent>; | |||
| controlErrorComponentAnchorFn?: (hostElement: Element, errorElement: Element) => () => void; | |||
| controlErrorsOn?: { | |||
There was a problem hiding this comment.
Please change to:
{
controlErrorsOn: {
async: boolean;
blur: boolean;
change: boolean;
}
}There was a problem hiding this comment.
updated. I kept them optional, is that ok?
NetanelBasal
approved these changes
May 24, 2022
added 2 commits
May 24, 2022 09:17
Docs are also updated now. |
|
Thank you for merging so quickly! Could you publish a new version to npm? |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#62
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Errors are shown after blur (+ after that on change). There is an option to disable showing the errors on blur: in that case they will only be shown on submit of the form. There is no option to always show/hide the errors on every change.
Issue Number: #62
What is the new behavior?
Default behavior stays the same. Pre-existing options also remain the same.
A new option was added:
controlErrorsOnChange. This will befalseby default. When set totrue, it will show/hide the errors always on change.Additionally, a global configuration option was added which makes it possible to override the default values for
controlErrorsOnAsync,controlErrorsOnBlurandcontrolErrorsOnChange.Does this PR introduce a breaking change?
Other information