Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiply css classes for control error component #54

Merged
merged 1 commit into from
Nov 29, 2021
Merged

feat: multiply css classes for control error component #54

merged 1 commit into from
Nov 29, 2021

Conversation

kmisha
Copy link
Contributor

@kmisha kmisha commented Nov 29, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently, we can use only one class for the control-error component.

Issue Number: #31

What is the new behavior?

The directive allow for multiple classes as string and array.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

close #31

@NetanelBasal NetanelBasal merged commit c439a61 into ngneat:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple css classes to be specified using customErrorsClass
2 participants