Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct use of the global window object #13

Closed
FFKL opened this issue Sep 6, 2021 · 2 comments
Closed

Direct use of the global window object #13

FFKL opened this issue Sep 6, 2021 · 2 comments

Comments

@FFKL
Copy link
Contributor

FFKL commented Sep 6, 2021

I'm submitting a...


[x] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

dirtyCheck operator uses global window object.

observer.add(
fromEvent(window, 'beforeunload')
.pipe(withLatestFrom(isDirty$))

Expected behavior

I think, It's better to pass window option in config.

What is the motivation / use case for changing the behavior?

Current behavior leads to restrictions on the use of SSR. Also it's impossible to apply dirtyCheck without beforeunload event.

@FFKL
Copy link
Contributor Author

FFKL commented Sep 6, 2021

@NetanelBasal Of course, I can implement it.

@NetanelBasal
Copy link
Member

Go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants