Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace params.modules with PublishDir and process.ext settings. #1283

Closed
11 tasks
mahesh-panchal opened this issue Oct 11, 2021 · 2 comments
Closed
11 tasks

Comments

@mahesh-panchal
Copy link
Member

mahesh-panchal commented Oct 11, 2021

Feature request: Replace params.modules with publishDir and ext.

This issue is a collection point for discussions on various topics regarding nf-core/rnaseq#701.

Is your feature request related to a problem? Please describe

PublishDir and tool arg configuration is distributed in many places in the nf-core workflows.
Using publishDir and process selectors could remedy file publishing configuration to be in one place.
Using ext.args and process selectors could provide tool parameters configuration in one place.

Describe the solution you'd like

nf-core/rnaseq#701 shows it implemented in the nf-core rnaseq workflow.

Current discussion points:

TODO list

  • Updating nf-core/modules
  • Update module template
    • Remove/Amend function import
    • Remove options
    • Use Jinja to write versions.yml process names
    • Remove publishDir.
  • Update pipeline template
  • lib/ (if keeping getSoftwareName, getProcessName).
  • Update linter to check for mode: params.publish_dir_mode.
  • Update linter to check for enabled:false, pattern: , or saveAs: { filename -> filename.equals('versions.yml') ? null : filename } so versions.yml is not published along with module outputs.
  • Update tests to use publishDir in config and remove NF_CORE_MODULES_TEST=1 env.
@mahesh-panchal
Copy link
Member Author

Added update of what removing functions.nf would look like here: https://github.com/mahesh-panchal/rnaseq/pull/1

@drpatelh drpatelh added this to Modules in Hackathon-October-2021 Oct 11, 2021
@drpatelh drpatelh moved this from Modules to nf-core DSL2 v2.0 in Hackathon-October-2021 Oct 11, 2021
@drpatelh
Copy link
Member

drpatelh commented Oct 11, 2021

Created individual issues for these @mahesh-panchal so we can track and discuss on them separately.

#1285
#1286
#1287

@drpatelh drpatelh removed this from nf-core DSL2 v2.0 in Hackathon-October-2021 Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants