Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-detect usage of Illumina iGenomes reference #808

Closed
drpatelh opened this issue Apr 26, 2022 · 2 comments
Closed

Auto-detect usage of Illumina iGenomes reference #808

drpatelh opened this issue Apr 26, 2022 · 2 comments
Labels
enhancement WIP Work in progress
Milestone

Comments

@drpatelh
Copy link
Member

Description of feature

As discussed on Slack here the aim of this feature is to make the latest versions of STAR the default now for all routes through the pipeline. There seem to be a number of fixes in recent versions of STAR that overcome weird seg faults and other issues that have been reported by users. We have stuck to an older version until now because the pipeline by default uses older indices from AWS iGenomes. Ideally, we would be able to auto-detect when AWS iGenomes is being used and switch to the appropriate container.

The plan is to auto-detect whether a --fasta called genome.fa is being used as well as a --gtf called genes.gtf. We can then have a switch in the pipeline that uses this information to determine which version of the container to use. This is the native naming convention used by all references on AWS iGenomes. However, this won't work in instances where users have renamed custom references downstream to follow this convention. In these relatively rare instances I think it makes sense to then use a custom config to re-define the containers:

process {
    withName: 'STAR_ALIGN' {
        container = 'quay.io/biocontainers/mulled-v2-1fa26d1ce03c295fe2fdcf85831a92fbcbd7e8c2:59cdd445419f14abac76b31dd0d71217994cbcc9-0'
    }

    withName: 'STAR_GENOMEGENERATE' {
        container = 'quay.io/biocontainers/mulled-v2-1fa26d1ce03c295fe2fdcf85831a92fbcbd7e8c2:59cdd445419f14abac76b31dd0d71217994cbcc9-0'
    }
}
@drpatelh
Copy link
Member Author

The option to build and push the latest STAR indices to AWS iGenomes was also discussed but this doesn't make sense with the impending shift to using Refgenie for reference genome management.

@drpatelh
Copy link
Member Author

Fixed in #810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement WIP Work in progress
Projects
None yet
Development

No branches or pull requests

1 participant