Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix annoying PRESEQ failure for methylseq #5091

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

maxulysse
Copy link
Member

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

modules/nf-core/preseq/lcextrap/main.nf Outdated Show resolved Hide resolved
@maxulysse maxulysse added this pull request to the merge queue Mar 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2024
@maxulysse maxulysse added this pull request to the merge queue Mar 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2024
@maxulysse maxulysse added this pull request to the merge queue Mar 11, 2024
Merged via the queue into nf-core:master with commit 4d178c5 Mar 11, 2024
11 checks passed
@maxulysse maxulysse deleted the preseq_lcextrap branch March 11, 2024 10:51
@edmundmiller
Copy link
Contributor

Shouldn't this be upstreamed to modules or this should have bumped the version?

jch-13 pushed a commit to jch-13/modules that referenced this pull request Mar 19, 2024
* fix annoying PRESEQ failure for methylseq

* Update modules/nf-core/preseq/lcextrap/main.nf

Co-authored-by: Phil Ewels <[email protected]>

---------

Co-authored-by: Phil Ewels <[email protected]>
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
* fix annoying PRESEQ failure for methylseq

* Update modules/nf-core/preseq/lcextrap/main.nf

Co-authored-by: Phil Ewels <[email protected]>

---------

Co-authored-by: Phil Ewels <[email protected]>
@ewels
Copy link
Member

ewels commented Mar 22, 2024

Shouldn't this be upstreamed to modules

This is modules...? I don't understand.

I don't think that a version bump is required to add this flag.

@ewels
Copy link
Member

ewels commented Mar 22, 2024

I don't think that a version bump is required to add this flag.

Though it looks like 3.2.0 is available..

@edmundmiller
Copy link
Contributor

This is modules...? I don't understand.

Don't mind me, saw methylseq in the title and misread it I guess 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants