Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xz/decompress: adds stub and stub test, improves tests and meta.yml #4580

Merged
merged 3 commits into from
Dec 12, 2023
Merged

xz/decompress: adds stub and stub test, improves tests and meta.yml #4580

merged 3 commits into from
Dec 12, 2023

Conversation

leoisl
Copy link
Contributor

@leoisl leoisl commented Dec 12, 2023

This PR adds stub and stub test, improves tests and meta.yml for module xz/decompress

@leoisl leoisl requested a review from a team as a code owner December 12, 2023 08:37
lrauschning
lrauschning requested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@lrauschning lrauschning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, same as for compress.
Once again, only think in the output the output shouldn't be deleted.

modules/nf-core/xz/decompress/meta.yml Outdated Show resolved Hide resolved
@leoisl leoisl added this pull request to the merge queue Dec 12, 2023
Merged via the queue into nf-core:master with commit 99cdd5f Dec 12, 2023
11 checks passed
@leoisl leoisl deleted the xz_decompress branch December 12, 2023 20:16
GallVp pushed a commit to GallVp/nf-modules that referenced this pull request Dec 12, 2023
@leoisl @GallVp
xz/decompress: adds stub and stub test, improves tests and meta.yml (n…
dbcff36 
…f-core#4580)

* fix: add stub section and improve tests for xz/decompress

* fix: improve metadata for xz/decompress, removing a linting warning

* fix: adding output.meta back to meta.yml
lrauschning pushed a commit to lrauschning/modules that referenced this pull request Dec 21, 2023
@leoisl @lrauschning
xz/decompress: adds stub and stub test, improves tests and meta.yml (n…
491b8ff 
…f-core#4580)

* fix: add stub section and improve tests for xz/decompress

* fix: improve metadata for xz/decompress, removing a linting warning

* fix: adding output.meta back to meta.yml
lrauschning pushed a commit to lrauschning/modules that referenced this pull request Jan 17, 2024
@leoisl @lrauschning
xz/decompress: adds stub and stub test, improves tests and meta.yml (n…
cda0bb8 
…f-core#4580)

* fix: add stub section and improve tests for xz/decompress

* fix: improve metadata for xz/decompress, removing a linting warning

* fix: adding output.meta back to meta.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrauschning lrauschning lrauschning approved these changes

@Aratz Aratz Awaiting requested review from Aratz Aratz is a code owner automatically assigned from nf-core/nf-test

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leoisl @lrauschning