-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVENT.IP_ADDRESS does not hold some addresses and do crash #6136
Comments
That a multihomed mirth engine with all those IPs? |
If there's an X-Forwarded-For header on messages that hit the Mirth API endpoint it uses that for the IP_ADDRESS. connect/core-server-plugins/src/com/mirth/connect/server/api/MirthServlet.java Lines 334 to 342 in bde0bdb
|
Interesting @ab-mg-23 , why all three then? Meaing I would expect the single IP. |
Client address and two pass through proxies. https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For |
This would affect all DB engines and is not Oracle specific. Increasing the column the size to ~120 characters is a good workaround. 120 chars should have room for three IPv6 addresses and any separator characters. I think the correct solution would be to properly parse the X-Forwarded-For header and store the first IP address in the comma separated list. |
for some reason my issue raised with a value of 50
while the maximum lenght is coded as 40 as seems in
connect/server/dbconf/oracle/oracle-database.sql
Line 13 in bde0bdb
I did fix the Oracle with
ALTER TABLE MIRTH.EVENT MODIFY IP_ADDRESS VARCHAR2(120);
then the saved value results to be a triple private ipv4 as follows
10.56.111.229:53709, 10.190.160.116, 10.188.160.68
The text was updated successfully, but these errors were encountered: