-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IDEA] Identify JVM and JVM parameters on start and DON'T start if some conflict exists. #5397
Comments
Examples: This manifests as exceptions like:
The ideal solution would:
I believe this solution can actually be implemented as a |
Can we just change this issue to "require Java 11/17/whatever+" and finally move-on from Java 8? |
Until some new thing comes along that requires yet another required modification, so "sorta". |
Perhaps mcservice and mcserver (the startup scripts) can just handle this automagically. e.g.: #!/bin/bash
# Get Java version
java_version=$(java -version 2>&1 | head -1 | cut -d'"' -f2 | sed '/^1\./s///' | cut -d'.' -f1)
echo $java_version
# Set JVM arguments based on Java version
if [[ "$java_version" -ge 11 ]]; then
jvm_extra_args="--add-modules java.xml.bind ......"
fi |
I would refine @pacmano1 idea to ONLY alter the modules for Java versions and NOT xmx or other vmopts. I would perhaps refine it as This has to be controllable by install4j. The This appears to be the feature - https://www.ej-technologies.com/resources/install4j/help/doc/concepts/vmParameters.html |
I'm a little curious why they use install4j at all. It's just not that hard to look for JAVA_HOME is some obvious places and bail if it's not found. Building a classpath from a few directories of JAR files is also not hard. |
Is your feature request related to a problem? Please describe.
Users install Mirth and expeect it to run without configuring things like java 9+ options.
Describe your use case
Based on number of people that don't read the manual to see java 9+ instuctions and/or other related problem to the choice of JVM version and/or options, it seems that Mirth should just detect its JVM and parameters and not start if there is a conflict.
Describe the solution you'd like
On start, identify conflicting JVM options. Log to mirth.log problems and don't start. Also, it's probably time to have java 9+ options installed by default.
Describe alternatives you've considered
Putting a critical readme like java 9+ front and formost in the documentation, it is buried.
Additional context
None really, just seems like an easy thing to do to reduce support burdens.
The text was updated successfully, but these errors were encountered: