Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Do not allow exiting filter editor if first step is disabled and "AND"ed or "OR"ed with the second step. #4470

Open
pacmano1 opened this issue Mar 7, 2021 · 9 comments
Labels
bug Something isn't working Internal-Issue-Created An issue has been created in NextGen's internal issue tracker RS-5990 triaged

Comments

@pacmano1
Copy link
Collaborator

pacmano1 commented Mar 7, 2021

The channel doesn't deploy of course in 3.10.1. But the admin tool should not allow the condition at all. Pic attached.

mirthbug

@pacmano1 pacmano1 added the bug Something isn't working label Mar 7, 2021
@cturczynskyj cturczynskyj added Internal-Issue-Created An issue has been created in NextGen's internal issue tracker RS-5990 triaged labels Mar 8, 2021
@cturczynskyj
Copy link
Collaborator

cturczynskyj commented Mar 8, 2021

Hmm, yeah, that probably should "not" be allowed. Internal issue created.

@pacmano1
Copy link
Collaborator Author

pacmano1 commented Mar 8, 2021

Should "not" be allowed. :)

@MichaelLeeHobbs
Copy link

Reported this a long time ago but can't find it. It should be allowed it's just that the auto generate code is wrong.

@cturczynskyj
Copy link
Collaborator

To clarify, we should not be allowing a channel to be saved in an undeployable state. There are two options on how we would do this:

  1. Do not allow the channel to be saved in this state
  2. Make whatever filter is the first enabled be the first filter and and/or others that follow

@pacmano1
Copy link
Collaborator Author

I'd just complain about it on exiting the filter.

@MichaelLeeHobbs
Copy link

I vote 2

@WTFHello
Copy link

WTFHello commented Nov 9, 2021

hmmm.

@twest-mirthconnect
Copy link
Contributor

We have triaged this ticket and will move forward with the following behavior change:

  • Make whatever filter is the first enabled be the first filter and/or others that follow

We will work through when to include it in a future build

@rogin
Copy link

rogin commented Jun 9, 2023

Comments in the Mirth slack shows another user bit by this today in his Production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Internal-Issue-Created An issue has been created in NextGen's internal issue tracker RS-5990 triaged
Projects
None yet
Development

No branches or pull requests

6 participants