Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't remove all messages after disabling message storage #3441

Open
rbeckman-nextgen opened this issue May 11, 2020 · 1 comment
Open

Can't remove all messages after disabling message storage #3441

rbeckman-nextgen opened this issue May 11, 2020 · 1 comment

Comments

@rbeckman-nextgen
Copy link
Collaborator

If a user disables message storage, then wants to remove all previously stored messages, the remove all messages action will clear the message stats but will not remove any messages.

This is happening because disabling storage sets PassthruDao as the DonkeyDao implementation and PassthruDao.deleteAllMessages currently does nothing. However it probably should be deleting all messages as JdbcDao normally does since messages could exist if the user previously had message storage enabled.

Imported Issue. Original Details:
Jira Issue Key: MIRTH-3545
Reporter: brentm
Created: 2014-12-09T09:27:00.000-0800

@rbeckman-nextgen rbeckman-nextgen added this to the 3.10.0 milestone May 11, 2020
@rbeckman-nextgen
Copy link
Collaborator Author

We could used the DAO from Donkey instead of getting it from the channel's DaoFactory when removing all messages. However for clearing statistics we would still have to use the PassThruDao?

Imported Comment. Original Details:
Author: wayneh
Created: 2014-12-22T20:26:56.000-0800

@cturczynskyj cturczynskyj removed this from the 3.10.0 milestone Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants