Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): fix broken link #10976

Merged
merged 9 commits into from
Jul 2, 2024

Conversation

k-taro56
Copy link
Contributor

☕️ Reasoning

Fix broken link.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Fixes: #10975

📌 Resources

@k-taro56 k-taro56 requested a review from ThangHuuVu as a code owner May 20, 2024 18:04
Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2024 1:05pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jun 30, 2024 1:05pm

Copy link

vercel bot commented May 20, 2024

@k-taro56 is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@5c49f95). Learn more about missing BASE report.

Current head 6832d9f differs from pull request most recent head 39f3b68

Please upload reports for the commit 39f3b68 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10976   +/-   ##
=======================================
  Coverage        ?   39.92%           
=======================================
  Files           ?      179           
  Lines           ?    28669           
  Branches        ?     1249           
=======================================
  Hits            ?    11445           
  Misses          ?    17224           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThangHuuVu
Copy link
Member

on second thought, I think we can just keep it as is in the source code, and add a redirect rule to our doc page:

"redirects": [

that way is cleaner IMO, how do you think?

@ThangHuuVu ThangHuuVu self-requested a review June 29, 2024 16:10
@github-actions github-actions bot removed the core Refers to `@auth/core` label Jun 30, 2024
@k-taro56
Copy link
Contributor Author

on second thought, I think we can just keep it as is in the source code, and add a redirect rule to our doc page:

"redirects": [

that way is cleaner IMO, how do you think?

Done!

@ThangHuuVu ThangHuuVu merged commit 7cf89a4 into nextauthjs:main Jul 2, 2024
11 of 13 checks passed
@ThangHuuVu
Copy link
Member

many thanks @k-taro56 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

https://authjs.dev/guides - page not found
2 participants