-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Dcorr/Energy/MMD/Hsic into scipy #98
Comments
Can I be assigned to this issue? |
I've added the distance_correlation function (and its helpers) to my fork of SciPy in the ben-master branch. The distance_correlation function is modeled off of the multiscale_graphcorr function which is already merged into SciPy and the helpers are from the hyppo repo (primarily the dcorr function). I've also added a simple test (more to see that the code runs and returns an expected result rather than for accuracy). The function passes the test. This link goes directly to the distance_correlation function which relies on multiple other functions in the _stats.pyx file. See attached screenshot of the test passed. Tests are in the same branch here. @sampan501 Suggested future steps include:
|
None of the functions that you added have been Cythonized. All the functions added use |
Then I don’t really understand why cythonizing is necessary if pure python works. @sampan501 |
Pure python is slow. With large datasets, it will long time to run. |
Oh I see. I wasn't aware of that being an essential part for any reason beyond making the code run-able in SciPy. |
Updates:
|
Documentation for the |
Can I be assigned this issue? |
No description provided.
The text was updated successfully, but these errors were encountered: