Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .sf instead of 1-.cdf for chi square approximation #87

Closed
bdpedigo opened this issue May 13, 2020 · 0 comments · Fixed by #88
Closed

Use .sf instead of 1-.cdf for chi square approximation #87

bdpedigo opened this issue May 13, 2020 · 0 comments · Fixed by #88
Labels
bug Something isn't working

Comments

@bdpedigo
Copy link
Contributor

From scipy docs:

sf(x, df, loc=0, scale=1) | Survival function (also defined as 1 - cdf, but sf is sometimes more accurate).

Pvals for Dcorr W/current code using chi-square approximation

Axon input 3.910265e-08
Dendrite input 0.000000e+00
Axon output 0.000000e+00
Dendrite output 0.000000e+00

Pvals for Dcorr using .sf instead

Axon input 3.910265e-08
Dendrite input 5.113893e-56
Axon output 5.723019e-106
Dendrite output 2.767278e-99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use .sf instead of 1 - .cdf for chi-square approximation neurodata/hyppo
1 participant
@bdpedigo