Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The statistic returned by the test method is different to the statistic returned by the statistic method #330

Closed
oakla opened this issue Jul 24, 2022 · 1 comment · Fixed by #336
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@oakla
Copy link
Contributor

oakla commented Jul 24, 2022

My issue is about ...
For independence tests, the test method returns a statistic that is different to the statistic returned by the statistic method. It seems that the statistic returned by the test method has been 'corrected' based on properties of the null distribution. This might be confusing to some people. Maybe it would be nice to mention it in the documentation rather than them having to dig through source code to figure out what is happening?

Snapshot of documentation error:

image

Additional context

I'm pretty novice when it comes to these things, so forgive me if this is one of those common practices that everyone but me knows about.

@oakla oakla added the documentation Improvements or additions to documentation label Jul 24, 2022
@sampan501 sampan501 added the bug Something isn't working label Aug 16, 2022
@sampan501
Copy link
Member

Is this only for Friedman Rafsky, or other tests in hyppo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants