Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbf and guassian in compute_kern are not the same #195

Closed
j1c opened this issue May 6, 2021 · 1 comment · Fixed by #196
Closed

rbf and guassian in compute_kern are not the same #195

j1c opened this issue May 6, 2021 · 1 comment · Fixed by #196
Labels
bug Something isn't working

Comments

@j1c
Copy link
Member

j1c commented May 6, 2021

The docstring says

hyppo/hyppo/tools/common.py

Line 120 in f7df5bb

Note ``"rbf"`` and ``"gaussian"`` are the same metric.

but this line doesn't check if the input is rbf or gaussian

hyppo/hyppo/tools/common.py

Line 141 in f7df5bb

if metric == "gaussian":

So rbf and gaussian would be a little different since the gamma for rbf will be the sklearn default of 1.0 / n_features. Should that line also check for rbf?
@j1c j1c added the bug Something isn't working label May 6, 2021
@sampan501
Copy link
Member

Yes good catch. I'll fix that

@sampan501 sampan501 mentioned this issue May 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make median kernel default for rbf and gaussian neurodata/hyppo
2 participants
@j1c @sampan501