Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the range of each independence test statistic to docs #121

Open
CaseyWeiner opened this issue Sep 14, 2020 · 17 comments
Open

Add the range of each independence test statistic to docs #121

CaseyWeiner opened this issue Sep 14, 2020 · 17 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@CaseyWeiner
Copy link

I think MGC test statistic is in the interval [-1, 1] and the rest are [0,1]?

@sampan501 sampan501 added the good first issue Good for newcomers label Mar 16, 2021
@oakla
Copy link
Contributor

oakla commented Feb 13, 2022

Would I be correct in thinking this is probably the easiest issue on the list?

@sampan501
Copy link
Member

yes, minor docstring edits

@oakla
Copy link
Contributor

oakla commented Feb 15, 2022

I'm on it. I've created a fork.

If I understand correctly, I'm suppose to link my pull request to this issue once i've finished coding the solution.

@oakla
Copy link
Contributor

oakla commented Feb 19, 2022

I think MGC test statistic is in the interval [-1, 1] and the rest are [0,1]?

Can i assume these values are correct, or is it worth taking the time to verify it myself?

@sampan501
Copy link
Member

Those aren't correct, most are [-1, 1] while some like HHG have no clear interval. I think it's worth taking time to verify, especially if you are learning a lot!

@Kshitij2001
Copy link

Can you please assign me this issue?

@oakla
Copy link
Contributor

oakla commented Jun 20, 2022

I've been working on and off this issue for a while. So I can submit some of my progress, can we break this issue into separate issues for each test?

@sampan501
Copy link
Member

Yes we can. Can you make a new issue for the tests you have done and then open a PR linking to that issue?

@oakla
Copy link
Contributor

oakla commented Aug 1, 2022

I made a PR for one of the tests last week. There's been no comment on it yet

@sampan501
Copy link
Member

Hi I'm currently out of the country and haven't reviewed any PRs made in the last week. I'll review them when I get back.

@vikram-8290
Copy link

i want to work on this issue.Can you please assign me this issue?

@vikram-8290
Copy link

i have made pull request .Please Let me know If have done it correctly or not(bcuz its my first open source issue).

@sampan501
Copy link
Member

So the pull request was correct, but that part of the documentation was already correct.

For this issue, really we want someone to go through each of the papers and find the range of each test statistic. For example, the RV test statistic has values between -1 and 1.

@vikram-8290 vikram-8290 removed their assignment Feb 28, 2023
@GargRaghav17
Copy link

hey... what papers are you talking about?
\

So the pull request was correct, but that part of the documentation was already correct.

For this issue, really we want someone to go through each of the papers and find the range of each test statistic. For example, the RV test statistic has values between -1 and 1.

@sampan501
Copy link
Member

Each paper has an associated paper that will likely be find in the docs. I believe each of them should have the range specified for the statistic. If you find some that don't, let me know

@arshm06
Copy link

arshm06 commented Jul 31, 2023

Hello! I have made a pull request for the RV test statistic. Thank you!

@oakla
Copy link
Contributor

oakla commented Jul 31, 2024

... really we want someone to go through each of the papers and find the range of each test statistic.

haha, looking at this thread years after I had a go at this issue. I had been trying to find the ranges by doing a lot of maths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

7 participants