fix: simplify file watching expression #6030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 02965a5
|
lukasholzer
reviewed
Oct 2, 2023
| @@ -548,7 +548,7 @@ export class EdgeFunctionsRegistry { | |||
| * @returns {Promise<void>} | |||
| */ | |||
| async #setupWatcherForDirectory(directory) { | |||
| const ignored = [new RegExp(this.#servePath)] | |||
| const ignored = [`${this.#servePath}/**`] | |||
There was a problem hiding this comment.
is this using unix paths on windows as well, I guess so but just checking.
There was a problem hiding this comment.
| @@ -30,9 +30,9 @@ const routes = [ | |||
| }, | |||
| ] | |||
|
|
|||
| describe('edge functions', () => { | |||
| describe.skipIf(isWindows)('edge functions', () => { | |||
There was a problem hiding this comment.
why are they skipped on windows? shouldn't it work there as well?
There was a problem hiding this comment.
cli/tests/integration/commands/dev/edge-functions.test.ts
Lines 9 to 10 in e08a47f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #6018 addressing a couple of items from the code review.