build: add and use TARNAME instead of NAME for paths

[kmk3]

PACKAGE_TARNAME is the same as PACKAGE_NAME but normalized, so it should
be safer to use in paths. For example, on a downstream project, if
spaces or shell metacharacters are added to the package name, a path
that uses PACKAGE_TARNAME should keep working.

From the manual of GNU Autoconf (version 2.69):

-- Macro: AC_INIT (PACKAGE, VERSION, [BUG-REPORT], [TARNAME], [URL])
Process any command-line arguments and perform initialization and
verification.

 Set the name of the PACKAGE and its VERSION.  These are typically
 used in '--version' support, including that of 'configure'.  The
 optional argument BUG-REPORT should be the email to which users
 should send bug reports.  The package TARNAME differs from
 PACKAGE: the latter designates the full package name (e.g., 'GNU
 Autoconf'), while the former is meant for distribution tar ball
 names (e.g., 'autoconf').  It defaults to PACKAGE with 'GNU '
 stripped, lower-cased, and all characters other than
 alphanumerics and underscores are changed to '-'.

Note also that by default (on autoconf v2.69), DOCDIR=@docdir@ in
config.mk.in expands to the following in config.mk:

DOCDIR=${datarootdir}/doc/${PACKAGE_TARNAME}

[kmk3]

Partial error log of build_and_test from
https://github.com/netblue30/firejail/runs/7801934320:

cd sysutils && ./sysutils.sh 2>&1 | tee sysutils.log
[...]
/usr/bin/tar
TESTING: tar
spawn /bin/bash
firejail /bin/tar -cjvf firejail_t2 /usr/share/doc/firejail
runner@fv-az357-462:~/work/firejail/firejail/test/sysutils$ 
< /bin/tar -cjvf firejail_t2 /usr/share/doc/firejail        ��������
/bin/tar: Removing leading `/' from member names
/bin/tar: /usr/share/doc/firejail: Cannot stat: No such file or directory
/bin/tar: Exiting with failure status due to previous errors
runner@fv-az357-462:~/work/firejail/firejail/test/sysutils$ TESTING ERROR 1.1

[...]

cd sysutils && grep -a TESTING sysutils.log && ! grep -a -q "TESTING ERROR" sysutils.log
TESTING: cpio
TESTING: gzip
TESTING: xzdec
TESTING: xz
TESTING: less
Press RETURN to continue TESTING SKIP 1.2
TESTING: file
TESTING: tar
runner@fv-az357-462:~/work/firejail/firejail/test/sysutils$ TESTING ERROR 1.1
TESTING: ping
TESTING SKIP: no internet connection
make[1]: *** [Makefile:6: sysutils] Error 1
make: *** [Makefile:266: test-sysutils] Error 2
make[1]: Leaving directory '/home/runner/work/firejail/firejail/test'
##[error]Process completed with exit code 2.
Post job cleanup.

Likely reason: @docdir@ references ${PACKAGE_TARNAME}, so the
PACKAGE_TARNAME variable cannot simply be renamed to TARNAME.

Updated and force-pushed.

[netblue30]

all in, thanks!

[kmk3]

$ git show --pretty='%s%n%n%b---' 3bb8064

config.mk.in: move basic variables to the top

Move up the variables that are defined in the `AC_INIT` call on
configure.ac.

And put VERSION last, to match the usual `$(NAME)-$(VERSION)` usage.
---

diff --git a/config.mk.in b/config.mk.in
index fdab92cb5..2f02c42eb 100644
--- a/config.mk.in
+++ b/config.mk.in
@@ -7,6 +7,10 @@
 # up overriding the includer's intended default target (which by default is the
 # first target encountered).
 
+NAME=@PACKAGE_NAME@
+PACKAGE_TARNAME=@PACKAGE_TARNAME@
+VERSION=@PACKAGE_VERSION@
+
 prefix=@prefix@
 exec_prefix=@exec_prefix@
 bindir=@bindir@
@@ -15,9 +19,6 @@ datarootdir=@datarootdir@
 mandir=@mandir@
 sysconfdir=@sysconfdir@
 
-VERSION=@PACKAGE_VERSION@
-NAME=@PACKAGE_NAME@
-PACKAGE_TARNAME=@PACKAGE_TARNAME@
 DOCDIR=@docdir@
 HAVE_APPARMOR=@HAVE_APPARMOR@
 HAVE_CONTRIB_INSTALL=@HAVE_CONTRIB_INSTALL@

Misc: I noticed that this is also the same order that ./configure uses:

# Identity of this package.
PACKAGE_NAME='firejail'
PACKAGE_TARNAME='firejail'
PACKAGE_VERSION='0.9.71'
PACKAGE_STRING='firejail 0.9.71'