Fix teams ignoring input sources e.g. microphones #4779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusty-snake
requested changes
Dec 14, 2021
|
Sorry, I was trying to respect the ordering rules for pull requests. It's not a general problem, just any electron app that needs microphone input. Not applicable to Firefox |
rusty-snake
approved these changes
Dec 14, 2021
kmk3
reviewed
Dec 14, 2021
| @@ -13,6 +13,8 @@ ignore include whitelist-usr-share-common.inc | |||
| ignore novideo | |||
| ignore private-tmp | |||
|
|
|||
| ignore novideo | |||
There was a problem hiding this comment.
I think you meant ignore noinput.
|
Also, could you squash the commits and push? Example: git stash; git tag backup # just in case
git rebase -i "$(git merge-base master HEAD)..HEAD"
# Change all occurrences of "pick" to "fixup", except for the first one
# (This makes the first commit "absorb" all the other commits)
# Check if it looks good (if not, `git reset --hard backup` and try again)
# Then just push
git push --force-with-lease |
|
merged, thanks! |
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
teams-for-linux.profileandteams.profileboth includeelectron.profile, which has thenoinputoption, which blocks microphones and other input sources, so this option needs to be ignored.