Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noroot removes all user groups, nogroups redundant #3303

Open
neirenoir opened this issue Mar 27, 2020 · 1 comment
Open

noroot removes all user groups, nogroups redundant #3303

neirenoir opened this issue Mar 27, 2020 · 1 comment
Labels
enhancement New feature request

Comments

@neirenoir
Copy link
Contributor

I'm not sure if it is intended behaviour, but setting noroot as an option will remove all of the user's groups, regardless of whether nogroups is present or not. Right now, I had to configure the profile of a program to ignore both nogroups and noroot, but I could have done away ignoring only nogroups: I need some of my user's groups, but I don't need the program knowing about the existence of users other than mine, including root.

Could noroot be implemented in such a way that it does not overlap with nogroups, so I can set them both independently, or does noroot necessarily require the removal of other groups?

@rusty-snake
Copy link
Collaborator

$ groups
rusty-snake wheel games wireshark
$ firejail --noprofile groups
rusty-snake wheel games wireshark
$ firejail --noprofile --nogroups groups
rusty-snake
$ firejail --noprofile --noroot groups
rusty-snake games

😕 , there are exceptions for tty, audio, video, games.

static void clean_supplementary_groups(gid_t gid) {

IMHO the best would be that #2042 also applies to noroot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request
Projects
None yet
Development

No branches or pull requests

3 participants