Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI fail: error: comparison between signed and unsigned integer expressions #3174

Closed
Vincent43 opened this issue Jan 21, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Vincent43
Copy link
Collaborator

Since 80b5030 the Travis CI show following errors:

sandbox.c: In function ‘monitor_application’:

sandbox.c:340:15: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]

       if (pid == dhclient4_pid || pid == dhclient6_pid)

               ^

sandbox.c:340:39: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]

       if (pid == dhclient4_pid || pid == dhclient6_pid)

                                       ^

cc1: all warnings being treated as errors

make[1]: *** [sandbox.o] Error 1

make[1]: Leaving directory `/home/travis/build/netblue30/firejail/src/firejail'

make: *** [src/firejail] Error 2

The command "( ./configure --enable-fatal-warnings --prefix=/usr && make && sudo make install && make test-travis )" exited with 2.

It doesn't look related to aforementioned commit though.

@Vincent43 Vincent43 added the bug Something isn't working label Jan 21, 2020
@rusty-snake
Copy link
Collaborator

https://travis-ci.org/netblue30/firejail/builds shows me 94d018c as first broken commit.

@kris7t kris7t self-assigned this Jan 27, 2020
kris7t added a commit to kris7t/firejail that referenced this issue Jan 27, 2020
kris7t added a commit to kris7t/firejail that referenced this issue Jan 27, 2020
kris7t added a commit to kris7t/firejail that referenced this issue Jan 27, 2020
@kris7t
Copy link
Collaborator

kris7t commented Jan 28, 2020

Build is fixed by 93cecca

@kris7t kris7t closed this as completed Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants