Skip to content

Commit

Permalink
makefiles: include config.mk instead of common.mk where possible
Browse files Browse the repository at this point in the history
common.mk contains definitions for building programs and it includes
config.mk.

Some makefiles that include common.mk do not contain any targets for
building programs.  They depend only on configure-time variable
definitions (which are defined on config.mk) rather than anything
specific to common.mk.  So change their includes of common.mk to
config.mk.
  • Loading branch information
kmk3 committed May 26, 2022
1 parent ef3992d commit da98193
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/bash_completion/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
all: firejail.bash_completion

ROOT = ../..
include $(ROOT)/src/common.mk
include $(ROOT)/config.mk

firejail.bash_completion: firejail.bash_completion.in
gawk -f ../man/preproc.awk -- $(MANFLAGS) < $< > $@.tmp
Expand Down
2 changes: 1 addition & 1 deletion src/man/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
all: firecfg.man firejail.man firejail-login.man firejail-users.man firejail-profile.man firemon.man jailcheck.man

ROOT = ../..
include $(ROOT)/src/common.mk
include $(ROOT)/config.mk

%.man: %.txt
gawk -f ./preproc.awk -- $(MANFLAGS) < $< > $@
Expand Down
2 changes: 1 addition & 1 deletion src/zsh_completion/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
all: _firejail

ROOT = ../..
include $(ROOT)/src/common.mk
include $(ROOT)/config.mk

_firejail: _firejail.in
gawk -f ../man/preproc.awk -- $(MANFLAGS) < $< > $@.tmp
Expand Down

0 comments on commit da98193

Please sign in to comment.