Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signOut() not working on Chrome and Firefox #536

Open
12 tasks
PascalTurbo opened this issue Jan 26, 2021 · 1 comment
Open
12 tasks

signOut() not working on Chrome and Firefox #536

PascalTurbo opened this issue Jan 26, 2021 · 1 comment

Comments

@PascalTurbo
Copy link

I'm submitting a...

  • Regression (a behavior that used to work and stopped working in a new release)
  • [ X] Bug report
  • Performance issue
  • Feature request
  • Documentation issue or request
  • Other... Please describe:

Current behavior

Working on an app I'm using Angular 10 (not supported, I know). While testing on Safari 14 everything works fine. SignOut leads to signed out user. But with current Chrome and Firefox, the signOut Method doesn't sign out.

While analyzing the problem, the finalize() part in signOut() Method is never called on Firefox and Chrome. In Safari it is executed properly. I don't know why at the moment but I will try to investigate in this.

Expected behavior

User should get signed out.

Environment

Angular-Token version: 9.0.0-beta.0
Angular version: 10.2.3

Bundler

  • [ X] Angular CLI (Webpack)
  • Webpack
  • SystemJS

Browser:

  • [ X] Chrome (desktop) version 89.0.4340.0 (Chromium)
  • Chrome (Android) version XX
  • Chrome (iOS) version XX
  • [ X] Firefox version 84.0 (64-Bit)
  • [ X] Safari (desktop) version 14.0.1 (16610.2.11.51.8)
  • Safari (iOS) version XX
  • IE version XX
  • Edge version XX
@PascalTurbo
Copy link
Author

I've had a look at the code and found

signOut() returns an observable, that is never subscribed. The interesting thing is, that this seems to work on Safari and obviously on older versions of angular. Subscribing at this point shouldn't be a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant