-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getAuthDataFromParams call in tryLoadAuthData does not work #382
Comments
Just ran into this as well. Any idea when this will be fixed? |
I may be misreading the code, but I think whatever issue you are facing is not related to the validateToken not being called because in fact validateToken is also an observable and without a subscribe the call Note also that from looking at the code, the tryLoadAuthData is only called once, on init, so it isn't doing whatever you think it should be doing. |
In
you have
But the method "getAuthDataFromParams()" uses "this.activatedRoute.queryParams.subscribe...." (so observable)
And therefore the next condition "if (this.atCurrentAuthData)" in tryLoadAuthData is always "false"!
It is impossible to login the user within queryParams. But it is necessary!
Example: Reset password
And now i have to signin the user within query params because i will signin the user after update password. And this is impossible.
I think the solution is to call "validateToken()" in getAuthDataFromParams not in tryLoadAuthData..e.g. so
and tryLoadAuthData shows like so:
Furthermore it might resolve the previous issue #371
The text was updated successfully, but these errors were encountered: