Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUI: Terminal cursor blinks after exiting neovim #21609

Closed
RobbieClarken opened this issue Jan 1, 2023 · 6 comments · Fixed by #21625
Closed

TUI: Terminal cursor blinks after exiting neovim #21609

RobbieClarken opened this issue Jan 1, 2023 · 6 comments · Fixed by #21625
Labels
bug-regression wrong behavior that was introduced in a previous commit (please bisect) has:bisected issue has been tracked to a specific commit tui
Milestone

Comments

@RobbieClarken
Copy link

Neovim version (nvim -v)

NVIM v0.9.0-dev-590+g6ba34e21f

Vim (not Nvim) behaves the same?

no

Operating system/version

macOS 12.5.1

Terminal name/version

iTerm2 3.4.12

$TERM environment variable

xterm-256color

Installation

build from repo

How to reproduce the issue

  1. Have terminal cursor configured to be a solid block (this is the default in macOS Terminal):

    Screen Shot 2023-01-01 at 7 27 08 pm
  2. Install latest neovim from master branch.

  3. Open and close vim:

    nvim --clean
    :q
    

The terminal cursor will now be blinking whereas it should be solid:

nvim-blink.mp4

A git bisect indicates this bug was introduced in one of these two commits:

I was unable to compile 2448816.

I can replicate this in iTerm2 3.4.12 and Terminal 2.12.7.

Expected behavior

The terminal cursor should remain the solid (not blinking) block.

Actual behavior

The terminal cursor changed to be blinking.

@RobbieClarken RobbieClarken added the bug issues reporting wrong behavior label Jan 1, 2023
@zeertzjq zeertzjq added tui bug-regression wrong behavior that was introduced in a previous commit (please bisect) has:bisected issue has been tracked to a specific commit and removed bug issues reporting wrong behavior labels Jan 1, 2023
@ouuan
Copy link

ouuan commented Jan 3, 2023

I want to add one point: I use au VimLeave * set guicursor=a:ver1 to restore to vertical bar cursor style after leaving neovim, but now after exiting neovim the cursor is blinking block. My terminal is konsole 22.08.3.

@zeertzjq
Copy link
Member

zeertzjq commented Jan 3, 2023

I tested #21625 and it seems to make the behavior the same as v0.8.2 in Konsole. Can anyone check if #21625 fixes the problem for iTerm2?

@SanchayanMaity
Copy link
Sponsor Contributor

I tested #21625 and it seems to make the behavior the same as v0.8.2 in Konsole. Can anyone check if #21625 fixes the problem for iTerm2?

Was facing this same problem and this does seem to fix the problem. My test is with the foot terminal on Arch Linux.

@RobbieClarken
Copy link
Author

Can anyone check if #21625 fixes the problem for iTerm2?

I can confirm #21625 fixes the problem for iTerm2 and Terminal on mac.

@ObserverOfTime
Copy link
Contributor

I tested #21625 and it seems to make the behavior the same as v0.8.2 in Konsole.

It's almost the same, though possibly more correct.

My terminal cursor is a blinking underline and I was using this to restore it on exit:

au VimLeave * set guicursor=a:hor25

It broke with #18375 and #21625 fixes it, but I had to change that to get the blinking back:

au VimLeave * set guicursor=a:hor25-blinkon500

@syyyr
Copy link

syyyr commented Jan 3, 2023

I can confirm that #21625 fixes the issue for me with Terminator on Arch Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-regression wrong behavior that was introduced in a previous commit (please bisect) has:bisected issue has been tracked to a specific commit tui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants