fix(ex_normal): spam \n in Ex mode only if in Cmdline mode #17977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeertzjq
changed the title
zeertzjq
force-pushed
the
fix-ex-mode-regression
branch
from
316c104
to
a3b9ff3
Compare
zeertzjq
changed the title
When using :normal in Ex mode, the editor is no longer in Cmdline mode, but the exmode_active flag is still set, causing the wrong character to be spammed in Insert mode, leading to a hang.
zeertzjq
force-pushed
the
fix-ex-mode-regression
branch
from
a3b9ff3
to
ee33459
Compare
wsdjeg
added a commit
to SpaceVim/SpaceVim
that referenced
this pull request
Apr 9, 2022
In Ex mode `line('w$')` return 0, so we should not use Display
range for Ex mode.
neovim issues and pull requests:
- neovim/neovim#18050
- neovim/neovim#14311
- neovim/neovim#17986
- neovim/neovim#17977
close https://github.com/SpaceVim/SpaceVim/issues/4629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17924
When using
:normalin Ex mode, the editor is no longer in Cmdline mode, but theexmode_activeflag is still set, causing the wrong character to be spammed in Insert mode, leading to a hang.