fix(diagnostic): make open_float respect scope option set in vim.diagnostic.config
#17879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SmiteshP
commented
Mar 27, 2022
SmiteshP
commented
- Closes scope option of vim.diagnostic.open_float() does not respect option set in vim.diagnostic.config() #17878
|
Just rearranged the code such that the global options don't get overwritten. |
* make `open_float` respect `scope` option set in `vim.diagnostic.config` * Closes #17878
|
LGTM, let’s just make sure CI passes and then I’ll merge. |
dmitmel
pushed a commit
to dmitmel/neovim
that referenced
this pull request
Apr 16, 2022
…eovim#17879) * make `open_float` respect `scope` option set in `vim.diagnostic.config` * Closes neovim#17878
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.