Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mappings): considering map description when filtering #17423

Merged
merged 2 commits into from
Feb 16, 2022
Merged

feat(mappings): considering map description when filtering #17423

merged 2 commits into from
Feb 16, 2022

Conversation

shadmansaleh
Copy link
Contributor

@shadmansaleh shadmansaleh commented Feb 16, 2022 •
edited
Loading

Allows filtering map output by map description.

@shadmansaleh shadmansaleh mentioned this pull request Feb 16, 2022
Merged
@zeertzjq
Copy link
Member

Actually filtering <Nop> can be done using :filter /^$/ map.

@zeertzjq zeertzjq added needs:discussion issue needs attention from an expert, or PR proposes significant changes to architecture or API mappings key bindings labels Feb 16, 2022
@shadmansaleh
Copy link
Contributor Author

Actually filtering can be done using :filter /^$/ map.

You're right. Then can be dropped . What about / ?

@zeertzjq
Copy link
Member

:filter /\// map?

@shadmansaleh
Copy link
Contributor Author

:filter /// map?

Sure didn't think about escaping in pattern. Then just adding the desc based filter should be enough.

@zeertzjq zeertzjq removed the needs:discussion issue needs attention from an expert, or PR proposes significant changes to architecture or API label Feb 16, 2022
zeertzjq
zeertzjq reviewed Feb 16, 2022
View reviewed changes
src/nvim/getchar.c Outdated Show resolved Hide resolved
@shadmansaleh shadmansaleh changed the title fix: filter not considering map desc & rhs properly fix: :filter not considering map desc Feb 16, 2022
@zeertzjq
Copy link
Member

Also I think this should be feat: .

@zeertzjq zeertzjq merged commit 9a74c2b into neovim:master Feb 16, 2022
@zeertzjq zeertzjq changed the title fix: :filter not considering map desc feat(mappings): considering map description when filtering Feb 16, 2022
zeertzjq added a commit that referenced this pull request Feb 16, 2022
@zeertzjq
Merge pull request #17424 from zeertzjq/map-followup
0852644 
follow-up PR to #17423
dmitmel pushed a commit to dmitmel/neovim that referenced this pull request Apr 16, 2022
@shadmansaleh @dmitmel
feat(mappings): considering map description when filtering (neovim#17423
8686831 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeertzjq zeertzjq zeertzjq left review comments

Assignees
No one assigned
Labels
mappings key bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shadmansaleh @zeertzjq