From aa17a48ed0f6c25ede5afb4f1a2836a19bb20729 Mon Sep 17 00:00:00 2001 From: Andrew Niculescu Date: Wed, 12 Oct 2022 07:41:19 -0700 Subject: [PATCH 1/7] Created two issue templates and updated the contribution doc. Fixes: neon-bindings/neon#865 --- .github/ISSUE_TEMPLATE/bug_report.yml | 75 ++++++++++++++++++++++++ .github/ISSUE_TEMPLATE/default_issue.yml | 67 +++++++++++++++++++++ CONTRIBUTING.md | 7 ++- 3 files changed, 146 insertions(+), 3 deletions(-) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.yml create mode 100644 .github/ISSUE_TEMPLATE/default_issue.yml diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml new file mode 100644 index 000000000..51a10f9d9 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -0,0 +1,75 @@ +name: "Found a Bug! 🐛" +title: "🐛 [BUG] - " +description: "Use this template to report a bug. Thank you!" +labels: ["bug"] +body: + - type: markdown + attributes: + value: | + Thanks in advance for taking the time to file this issue! + We hope this simple template will improve issue resolution time and minimize the need for _context discovery_ discussions. + ______ + **Note**: We encourage you to [submit an RFC](https://github.com/neon-bindings/rfcs) if you would like to propose a **design change** or a **new feature** for the Neon API or the Neon command-line tool. + ______ + + In addition to the `bug` label, consider adding others you might find relevant: + | Label | Description | + |:-----:|-------------| + | `CI` | Continuous Integration | + | `CLI` | Command Line Interface | + | `beginner friendly` | Great for those just starting out | + | `Performance` | Anything that affects performance | + | `linux` | Specific to Linux | + | `macos` | Specific to MacOS | + | `windows` | Specific to Windows | + | `android` | Specific to Android | + | `electron` | Specific to Electron apps | + - type: textarea + id: issue_summary + attributes: + label: Short Summary + description: Please provide a brief description of the issue + placeholder: "example: neon crashes when ..." + validations: + required: true + - type: textarea + id: issue_repro + attributes: + label: Steps to reproduce + description: "Help us reproduce this issue with some step-by-step instructions" + value: | + 1. + 2. + 3. + ... + validations: + required: true + - type: textarea + id: issue_fix + attributes: + label: Suggested fix + description: "If you have a proposed way to fix this bug, please summarize below. PRs work too :)" + - type: input + id: node_version + attributes: + label: "Node version: " + description: "Please specify the version of `node` you are running" + placeholder: "v18.10.0" + - type: input + id: npm_version + attributes: + label: "Node Package Manager version: " + description: "Please specify the version of `npm` you are running" + placeholder: "8.19.2" + - type: input + id: neon_version + attributes: + label: "NEON version(s): " + description: "Please specify the versions of `neon` that exhibit this issue" + placeholder: "example: v0.10.0, v0.9.x" + - type: input + id: os_version_arch + attributes: + label: OS Version + description: "Please provide your OS version and Architecture" + placeholder: "example: macOS 12.5.1 Intel" diff --git a/.github/ISSUE_TEMPLATE/default_issue.yml b/.github/ISSUE_TEMPLATE/default_issue.yml new file mode 100644 index 000000000..cc747edb9 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/default_issue.yml @@ -0,0 +1,67 @@ +name: New Issue +title: Neon Issue +description: Use this template for all issues that are not bugs. +body: + - type: markdown + attributes: + value: | + Thanks in advance for taking the time to file this issue! + If you think this is a 🐛 bug, please use the [bug issue template](https://github.com/neon-bindings/issues/new?assignees=&labels=&template=default_issue.yml&title=Neon+Issue). + + Otherwise, please help us stay organized by selecting one or more of the following labels as applicable to your new issue. + + | Label | Description | + |:-----:|-------------| + | `CI` | Continuous Integration | + | `CLI` | Command Line Interface | + | `beginner friendly` | Great for those just starting out | + | `enhancement` | For new features/design changes, use an [RFC](https://github.com/neon-bindings/rfcs) | + | `Performance` | Anything that affects performance | + | `linux` | Specific to Linux | + | `macos` | Specific to MacOS | + | `windows` | Specific to Windows | + | `android` | Specific to Android | + | `electron` | Specific to Electron apps | + + --- + - + attributes: + description: "Please provide a brief description of the issue" + label: "Short Summary" + placeholder: "example: the issue template should be dynamically generated..." + id: issue_summary + type: textarea + validations: + required: true + - + attributes: + value: "> For context, please give us some details of your setup:\n" + type: markdown + - + attributes: + description: "Please specify the version of `node` you are running" + label: "Node version: " + placeholder: v18.10.0 + id: node_version + type: input + - + attributes: + description: "Please specify the version of `npm` you are running" + label: "Node Package Manager version: " + placeholder: "8.19.2" + id: npm_version + type: input + - + attributes: + description: "Please specify the versions of `neon` that exhibit this issue" + label: "NEON version(s): " + placeholder: "example: v0.10.0, v0.9.x" + id: neon_version + type: input + - + attributes: + description: "Please provide your OS version and Architecture" + label: "OS Version" + placeholder: "example: macOS 12.5.1 Intel" + id: os_version_arch + type: input diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b136eddc4..665abe988 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,10 +6,11 @@ Neon welcomes contribution from everyone. Here are some resources to help you jo ### Issue reports -We welcome issues and aim to keep the barrier low. Just [file a GitHub issue](https://github.com/neon-bindings/neon/issues) -like normal---we don't require issue templates or have any particular process. +We welcome issues and aim to keep the barrier low. For clarity and efficiency, we created two simple issue templates: + - [Bug Report](https://github.com/neon-bindings/issues/new?assignees=&labels=bug&template=bug_report.yml&title=🐛+%5BBUG%5D+-+<title>) + - [General Neon Issue](https://github.com/neon-bindings/issues/new?assignees=&labels=&template=default_issue.yml&title=Neon+Issue) -That said, the more information you can provide to help us reproduce your issue, the better! +The more information you can provide, the better! Thanks in advance! ❤️ ### Requests For Comments From 0be505043def7ab53b33d1b2e291d42952057e24 Mon Sep 17 00:00:00 2001 From: Andrew Niculescu <andrew.niculescu@agilebits.com> Date: Wed, 12 Oct 2022 08:01:46 -0700 Subject: [PATCH 2/7] Prettier formatting --- .github/ISSUE_TEMPLATE/bug_report.yml | 4 +- .github/ISSUE_TEMPLATE/default_issue.yml | 62 +++++++++++------------- 2 files changed, 30 insertions(+), 36 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 51a10f9d9..b479d9160 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -11,7 +11,7 @@ body: ______ **Note**: We encourage you to [submit an RFC](https://github.com/neon-bindings/rfcs) if you would like to propose a **design change** or a **new feature** for the Neon API or the Neon command-line tool. ______ - + In addition to the `bug` label, consider adding others you might find relevant: | Label | Description | |:-----:|-------------| @@ -23,7 +23,7 @@ body: | `macos` | Specific to MacOS | | `windows` | Specific to Windows | | `android` | Specific to Android | - | `electron` | Specific to Electron apps | + | `electron` | Specific to Electron apps | - type: textarea id: issue_summary attributes: diff --git a/.github/ISSUE_TEMPLATE/default_issue.yml b/.github/ISSUE_TEMPLATE/default_issue.yml index cc747edb9..2ae9f8664 100644 --- a/.github/ISSUE_TEMPLATE/default_issue.yml +++ b/.github/ISSUE_TEMPLATE/default_issue.yml @@ -1,65 +1,59 @@ name: New Issue title: Neon Issue description: Use this template for all issues that are not bugs. -body: +body: - type: markdown - attributes: + attributes: value: | - Thanks in advance for taking the time to file this issue! - If you think this is a 🐛 bug, please use the [bug issue template](https://github.com/neon-bindings/issues/new?assignees=&labels=&template=default_issue.yml&title=Neon+Issue). - - Otherwise, please help us stay organized by selecting one or more of the following labels as applicable to your new issue. - - | Label | Description | - |:-----:|-------------| - | `CI` | Continuous Integration | - | `CLI` | Command Line Interface | - | `beginner friendly` | Great for those just starting out | - | `enhancement` | For new features/design changes, use an [RFC](https://github.com/neon-bindings/rfcs) | - | `Performance` | Anything that affects performance | - | `linux` | Specific to Linux | - | `macos` | Specific to MacOS | - | `windows` | Specific to Windows | - | `android` | Specific to Android | - | `electron` | Specific to Electron apps | - - --- - - - attributes: + Thanks in advance for taking the time to file this issue! + If you think this is a 🐛 bug, please use the [bug issue template](https://github.com/neon-bindings/issues/new?assignees=&labels=&template=default_issue.yml&title=Neon+Issue). + + Otherwise, please help us stay organized by selecting one or more of the following labels as applicable to your new issue. + + | Label | Description | + |:-----:|-------------| + | `CI` | Continuous Integration | + | `CLI` | Command Line Interface | + | `beginner friendly` | Great for those just starting out | + | `enhancement` | For new features/design changes, use an [RFC](https://github.com/neon-bindings/rfcs) | + | `Performance` | Anything that affects performance | + | `linux` | Specific to Linux | + | `macos` | Specific to MacOS | + | `windows` | Specific to Windows | + | `android` | Specific to Android | + | `electron` | Specific to Electron apps | + + --- + - attributes: description: "Please provide a brief description of the issue" label: "Short Summary" placeholder: "example: the issue template should be dynamically generated..." id: issue_summary type: textarea - validations: + validations: required: true - - - attributes: + - attributes: value: "> For context, please give us some details of your setup:\n" type: markdown - - - attributes: + - attributes: description: "Please specify the version of `node` you are running" label: "Node version: " placeholder: v18.10.0 id: node_version type: input - - - attributes: + - attributes: description: "Please specify the version of `npm` you are running" label: "Node Package Manager version: " placeholder: "8.19.2" id: npm_version type: input - - - attributes: + - attributes: description: "Please specify the versions of `neon` that exhibit this issue" label: "NEON version(s): " placeholder: "example: v0.10.0, v0.9.x" id: neon_version type: input - - - attributes: + - attributes: description: "Please provide your OS version and Architecture" label: "OS Version" placeholder: "example: macOS 12.5.1 Intel" From 7c1fb0fbb782e8672da543c2ea650c51f003fe5b Mon Sep 17 00:00:00 2001 From: Andrew Niculescu <andrew.niculescu@agilebits.com> Date: Sat, 12 Nov 2022 07:00:51 -0800 Subject: [PATCH 3/7] Remove labels table from bug issue template --- .github/ISSUE_TEMPLATE/bug_report.yml | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index b479d9160..9399424d1 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -11,19 +11,6 @@ body: ______ **Note**: We encourage you to [submit an RFC](https://github.com/neon-bindings/rfcs) if you would like to propose a **design change** or a **new feature** for the Neon API or the Neon command-line tool. ______ - - In addition to the `bug` label, consider adding others you might find relevant: - | Label | Description | - |:-----:|-------------| - | `CI` | Continuous Integration | - | `CLI` | Command Line Interface | - | `beginner friendly` | Great for those just starting out | - | `Performance` | Anything that affects performance | - | `linux` | Specific to Linux | - | `macos` | Specific to MacOS | - | `windows` | Specific to Windows | - | `android` | Specific to Android | - | `electron` | Specific to Electron apps | - type: textarea id: issue_summary attributes: From c621b4b276ba82ebc8e5765f47080628aadb3e43 Mon Sep 17 00:00:00 2001 From: Andrew Niculescu <andrew.niculescu@agilebits.com> Date: Sat, 12 Nov 2022 07:35:36 -0800 Subject: [PATCH 4/7] Simplify the default template, per comments --- .github/ISSUE_TEMPLATE/default_issue.yml | 64 ++++-------------------- 1 file changed, 10 insertions(+), 54 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/default_issue.yml b/.github/ISSUE_TEMPLATE/default_issue.yml index 2ae9f8664..9b6375fbe 100644 --- a/.github/ISSUE_TEMPLATE/default_issue.yml +++ b/.github/ISSUE_TEMPLATE/default_issue.yml @@ -1,61 +1,17 @@ -name: New Issue -title: Neon Issue -description: Use this template for all issues that are not bugs. +name: Other 🎫 +title: <issue title> +description: Use this template for all issues that are not bugs or feature requests. body: - - type: markdown - attributes: - value: | - Thanks in advance for taking the time to file this issue! - If you think this is a 🐛 bug, please use the [bug issue template](https://github.com/neon-bindings/issues/new?assignees=&labels=&template=default_issue.yml&title=Neon+Issue). - - Otherwise, please help us stay organized by selecting one or more of the following labels as applicable to your new issue. - - | Label | Description | - |:-----:|-------------| - | `CI` | Continuous Integration | - | `CLI` | Command Line Interface | - | `beginner friendly` | Great for those just starting out | - | `enhancement` | For new features/design changes, use an [RFC](https://github.com/neon-bindings/rfcs) | - | `Performance` | Anything that affects performance | - | `linux` | Specific to Linux | - | `macos` | Specific to MacOS | - | `windows` | Specific to Windows | - | `android` | Specific to Android | - | `electron` | Specific to Electron apps | - - --- - attributes: description: "Please provide a brief description of the issue" label: "Short Summary" - placeholder: "example: the issue template should be dynamically generated..." + placeholder: "example: this issue template should be dynamically generated..." id: issue_summary type: textarea validations: - required: true - - attributes: - value: "> For context, please give us some details of your setup:\n" - type: markdown - - attributes: - description: "Please specify the version of `node` you are running" - label: "Node version: " - placeholder: v18.10.0 - id: node_version - type: input - - attributes: - description: "Please specify the version of `npm` you are running" - label: "Node Package Manager version: " - placeholder: "8.19.2" - id: npm_version - type: input - - attributes: - description: "Please specify the versions of `neon` that exhibit this issue" - label: "NEON version(s): " - placeholder: "example: v0.10.0, v0.9.x" - id: neon_version - type: input - - attributes: - description: "Please provide your OS version and Architecture" - label: "OS Version" - placeholder: "example: macOS 12.5.1 Intel" - id: os_version_arch - type: input + required: false + - type: markdown + attributes: + value: | + > Thanks in advance for taking the time to file this issue! + > We appreciate it! \ No newline at end of file From 637eb87a37e9e589971ad941555c36b9a47f47fd Mon Sep 17 00:00:00 2001 From: Andrew Niculescu <andrew.niculescu@agilebits.com> Date: Sat, 12 Nov 2022 10:12:11 -0800 Subject: [PATCH 5/7] Feature Request issue template --- .github/ISSUE_TEMPLATE/feature_request.yml | 85 ++++++++++++++++++++++ 1 file changed, 85 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/feature_request.yml diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml new file mode 100644 index 000000000..f997d192b --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -0,0 +1,85 @@ +name: Feature Request (RFC) 💡 +title: <title> +description: Use this template for a new feature request or a design change. +labels: ["enhancement"] +body: + - type: input + attributes: + label: Feature Name + description: Give your feature a unique name + placeholder: "example: my_awesome_feature" + id: rfc_name + validations: + required: true + - type: input + id: rfc_date + attributes: + label: "Start Date" + placeholder: "fill me in with today's date, `YYYY-MM-DD`" + - type: input + id: rfc_pr + attributes: + label: RFC PR + placeholder: Leave this empty + - type: input + id: rfc_issue + attributes: + label: Neon Issue + placeholder: Leave this empty + - type: textarea + id: rfc_summary + attributes: + label: Summary + description: One paragraph explanation of the feature. + - type: textarea + id: rfc_motivation + attributes: + label: Motivation + description: | + Think about answering the following questions: + - Why are we doing this? + - What use cases does it support? + - What is the expected outcome? + - type: textarea + id: rfc_details + attributes: + label: Guide-level explanation + description: | + Explain the proposal as if it were already included in Neon and you were teaching it to another programmer. That generally means: + - Introducing new named concepts. + - Explaining the feature largely in terms of examples. + - Explaining how programmers should _think_ about the feature, and how it should impact the way they use Neon. It should explain the impact as concretely as possible. + - If applicable, describe the differences between teaching this to existing Rust programmers and new Rust programmers. + - type: textarea + id: rfc_tech_details + attributes: + label: Reference-level explanation + description: | + This is the technical portion of the RFC. Explain the design in sufficient detail that: + - Its interaction with other features is clear. + - It is reasonably clear how the feature would be implemented. + - Corner cases are dissected by example. + + This section should return to the examples given in the previous section, and explain more fully how the detailed proposal makes those examples work. + - type: textarea + id: rfc_drawbacks + attributes: + label: Drawbacks + description: | + Why should we _not_ do this? + - type: textarea + id: rfc_alternatives + attributes: + label: Rationale and alternatives + description: | + - Why is this design the best in the space of possible designs? + - What other designs have been considered and what is the rationale for not choosing them? + - What is the impact of not doing this? + - type: textarea + id: rfc_unresolved_questions + attributes: + label: Unresolved questions + description: | + - What parts of the design do you expect to resolve through the RFC process before this gets merged? + - What parts of the design do you expect to resolve through the implementation of this feature before stabilization? + - What related issues do you consider out of scope for this RFC that could be addressed in the future independently of the solution that comes out of this RFC? From 96a80444c09bb05ef8aaa0b03e573eb50dd7ccbe Mon Sep 17 00:00:00 2001 From: Andrew Niculescu <andrew.niculescu@agilebits.com> Date: Sat, 12 Nov 2022 16:08:44 -0800 Subject: [PATCH 6/7] Addressing feedback and linking the new feature request template --- .github/ISSUE_TEMPLATE/bug_report.yml | 15 ++++++--------- CONTRIBUTING.md | 10 +++------- 2 files changed, 9 insertions(+), 16 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 9399424d1..24c4a6a8f 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -8,9 +8,6 @@ body: value: | Thanks in advance for taking the time to file this issue! We hope this simple template will improve issue resolution time and minimize the need for _context discovery_ discussions. - ______ - **Note**: We encourage you to [submit an RFC](https://github.com/neon-bindings/rfcs) if you would like to propose a **design change** or a **new feature** for the Neon API or the Neon command-line tool. - ______ - type: textarea id: issue_summary attributes: @@ -43,15 +40,15 @@ body: description: "Please specify the version of `node` you are running" placeholder: "v18.10.0" - type: input - id: npm_version + id: pm_version attributes: - label: "Node Package Manager version: " - description: "Please specify the version of `npm` you are running" - placeholder: "8.19.2" + label: "Package Manager & version: " + description: "Please specify the package manager your are using and its version" + placeholder: "example: npm 8.19.2" - type: input id: neon_version attributes: - label: "NEON version(s): " + label: "Neon version(s): " description: "Please specify the versions of `neon` that exhibit this issue" placeholder: "example: v0.10.0, v0.9.x" - type: input @@ -59,4 +56,4 @@ body: attributes: label: OS Version description: "Please provide your OS version and Architecture" - placeholder: "example: macOS 12.5.1 Intel" + placeholder: "example: macOS 12.5.1 Intel" \ No newline at end of file diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 665abe988..a336ac84e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,20 +6,16 @@ Neon welcomes contribution from everyone. Here are some resources to help you jo ### Issue reports -We welcome issues and aim to keep the barrier low. For clarity and efficiency, we created two simple issue templates: +We welcome issues and aim to keep the barrier low. For clarity and efficiency, we created these simple issue templates: - [Bug Report](https://github.com/neon-bindings/issues/new?assignees=&labels=bug&template=bug_report.yml&title=🐛+%5BBUG%5D+-+<title>) - - [General Neon Issue](https://github.com/neon-bindings/issues/new?assignees=&labels=&template=default_issue.yml&title=Neon+Issue) - -The more information you can provide, the better! Thanks in advance! ❤️ + - [Other](https://github.com/neon-bindings/issues/new?assignees=&labels=&template=default_issue.yml&title=%3Cissue+title%3E) ### Requests For Comments If you would like to propose a design change or new feature for the Neon API or the `neon` command-line tool, we encourage you to [submit an RFC](https://github.com/neon-bindings/rfcs)! -The [RFC process](https://github.com/neon-bindings/rfcs#the-process) has a little more overhead than -filing an issue, but it's for the goal of allowing the Neon community to have a chance to vet -design ideas and reach consensus. And even at that, we've deliberately kept the [RFC template](https://github.com/neon-bindings/rfcs/blob/main/0000-template.md) +The [RFC process](https://github.com/neon-bindings/rfcs#the-process) has a little more overhead than filing an issue, but it's for the goal of allowing the Neon community to have a chance to vet design ideas and reach consensus. And even at that, we've deliberately kept the [RFC template](https://github.com/neon-bindings/issues/new?assignees=&labels=enhancement&template=feature_request.yml&title=%3Ctitle%3E) simple and open-ended. ### Good first bugs From f66fd07ec229a600cd36372a9797da0f7838a48b Mon Sep 17 00:00:00 2001 From: Andrew Niculescu <andrew.niculescu@agilebits.com> Date: Sat, 12 Nov 2022 16:15:31 -0800 Subject: [PATCH 7/7] Linting :( --- .github/ISSUE_TEMPLATE/bug_report.yml | 2 +- .github/ISSUE_TEMPLATE/default_issue.yml | 2 +- .github/ISSUE_TEMPLATE/feature_request.yml | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 24c4a6a8f..3e2bcb13f 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -56,4 +56,4 @@ body: attributes: label: OS Version description: "Please provide your OS version and Architecture" - placeholder: "example: macOS 12.5.1 Intel" \ No newline at end of file + placeholder: "example: macOS 12.5.1 Intel" diff --git a/.github/ISSUE_TEMPLATE/default_issue.yml b/.github/ISSUE_TEMPLATE/default_issue.yml index 9b6375fbe..afe4ddbb2 100644 --- a/.github/ISSUE_TEMPLATE/default_issue.yml +++ b/.github/ISSUE_TEMPLATE/default_issue.yml @@ -14,4 +14,4 @@ body: attributes: value: | > Thanks in advance for taking the time to file this issue! - > We appreciate it! \ No newline at end of file + > We appreciate it! diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index f997d192b..4720e2945 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -1,6 +1,6 @@ -name: Feature Request (RFC) 💡 +name: Feature Request (RFC) 💡 title: <title> -description: Use this template for a new feature request or a design change. +description: Use this template for a new feature request or a design change. labels: ["enhancement"] body: - type: input @@ -15,7 +15,7 @@ body: id: rfc_date attributes: label: "Start Date" - placeholder: "fill me in with today's date, `YYYY-MM-DD`" + placeholder: "fill me in with today's date, `YYYY-MM-DD`" - type: input id: rfc_pr attributes: @@ -25,7 +25,7 @@ body: id: rfc_issue attributes: label: Neon Issue - placeholder: Leave this empty + placeholder: Leave this empty - type: textarea id: rfc_summary attributes: @@ -59,7 +59,7 @@ body: - Its interaction with other features is clear. - It is reasonably clear how the feature would be implemented. - Corner cases are dissected by example. - + This section should return to the examples given in the previous section, and explain more fully how the detailed proposal makes those examples work. - type: textarea id: rfc_drawbacks