New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet.MakeTransaction() convert Base64 script via HexToBytes() straightly #381

Closed

superboyiii opened this issue Oct 30, 2020 · 0 comments · Fixed by #382

Member

superboyiii commented Oct 30, 2020

Describe the bug
wallet.MakeTransaction() convert Base64 script via HexToBytes() straightly

To Reproduce
Steps to reproduce the behavior:

Invoke openwallet via RPC
Invoke a method from sc
Exception comes out which shows incorrect string format

Expected behavior
Format exception comes out here.

neo-modules/src/RpcServer/RpcServer.Wallet.cs

Line 179 in ce24f59

 tx = wallet.MakeTransaction(result["script"].AsString().HexToBytes(), sender, witnessSigners); 

superboyiii mentioned this issue

Fix script convert in MakeTransaction(). #382

Merged

superboyiii closed this as completed in #382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment