Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some questions about inference.py #6

Open
JinY97 opened this issue Oct 18, 2022 · 1 comment
Open

Some questions about inference.py #6

JinY97 opened this issue Oct 18, 2022 · 1 comment

Comments

@JinY97
Copy link

JinY97 commented Oct 18, 2022

Hi, thank you for sharing your work! I have some confusion about it.

  • As shown in Eq.(17) in the paper,delta_bar[n] should be equal to (delta_cond[n])* delta[n] / delta[n-1]. However, the code shows that `delta_bar[n] = (delta_cond[n])* delta[n-1]/ delta[n]'.
  • The code shows that audio = noisy_audio (line 148), but according to Eq. (10), audio = alpha_cum[-1]**0.5 * noisy_signal + delta[-1] * torch.randn_like(noisy_signal).

Hope to obtain your answer, thank you!

@JinY97 JinY97 changed the title Some question about inference.py Some questions about inference.py Oct 18, 2022
@neillu23
Copy link
Owner

Hi @JinY97, thank you for your interest in CDiffuSE and your comment!

  • The code shows that audio = noisy_audio (line 148), but according to Eq. (10), audio = alpha_cum[-1]**0.5 * noisy_signal + delta[-1] * torch.randn_like(noisy_signal).

This implementation follows the practical technique in A Study on Speech Enhancement Based on Diffusion Probabilistic Model to start with the noisy speech signal. Also, since the alpha_cum[-1] is close to 1 and delta[-1] is close to 0, the starting signal (and the results) is similar to the ones in Eq. (10).

  • As shown in Eq.(17) in the paper,delta_bar[n] should be equal to (delta_cond[n])* delta[n] / delta[n-1]. However, the code shows that `delta_bar[n] = (delta_cond[n])* delta[n-1]/ delta[n]'.

I found this would be a typo in the paper, delta_bar[n] should be equal to (delta_cond[n])* delta[n-1]/ delta[n]. I will further update this in the Arxiv paper. Thanks for pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants