Adjust parser ordering to error out on invalid names #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See tianon/gosu@fd60171 and tianon/gosu@f87df69. The basic problem is that an invalid name like `bogus` will quietly run as `root` instead of being denied entirely (which those test updates look for and this change is verified to fix). I've run this updated implementation successfully against all of the test cases in https://github.com/tianon/gosu/blob/f87df69c868e19f7258b4facb7c2472d76d98dda/Dockerfile.test.
|
@ncopa Could you merge this, please? |
|
Friendly ping @ncopa 🙏 ❤️ Anything about this you'd like me to change/update? |
|
sorry, i completely missed this. |
|
fixed with 212b751 |
|
Any chance of a 0.3 with this change in it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tianon/gosu@fd60171 and tianon/gosu@f87df69.
The basic problem is that an invalid name like
boguswill quietly run asrootinstead of being denied entirely (which those test updates look for and this change is verified to fix).I've run this updated implementation successfully against all of the test cases in https://github.com/tianon/gosu/blob/f87df69c868e19f7258b4facb7c2472d76d98dda/Dockerfile.test.
(See also tianon/gosu#57 (comment) / tianon/gosu#60.)
Closes #6