Blackness

[amk221]

I run npm install frequently, and it looks like this:

However, I would expect it to look like this:

[nathanbuchar]

Thanks for trying it out :)

I believe the background color is applied on npm's side. I've looked through their code a little bit to see if I can find exactly where it's coming from but unfortunately that's no easy task.. However, here is the output in a Terminal window using the default "Basic" theme:

As you can see the background color for each module is still black, so I don't think it's related to the one-dark-terminal theme but rather npm itself, as that is how they've chosen to display tree views.

[amk221]

Ah thanks, nice spot.

[amk221]

Apologies if this a daft question, but why is black even a part of the One Dark theme?
If I change Black to the Background colour provided by One Dark theme, it looks fine as per my original screenshot.

[nathanbuchar]

That's a good point.. I'd be a bit hesitant to not have "Black" be "#000000", but if it won't cause any conflicts elsewhere I see no reason why not. Do you know where else this black color may be used?

[amk221]

I'm afraid I don't know enough about terminal colours... but Solarized Dark doesn't have Black

[nathanbuchar]

Good enough for me, I'll post an update tonight. Thanks for the tip!

[nathanbuchar]

This won't be solvable for the one-light theme, however. I'm not going to use #FFFFFF as "Black" haha, but for one-dark it shouldn't be an issue