Colors not chosen appropriately

[steelbrain]

This hurts my eyes

The text color shouldn't be so dull, it should be a little brighter

Another place this could be improved is parameters

[nathanbuchar]

Hey, thanks for trying it out!

This is of course personal preference – although I will admit that on many projects in the past I have been told that my choice of font colors are too light or dull and lacking in contrast. Personally I have never found an issue with them, but certainly from an accessibility prospective it could use more contrast. The contrast is also dependent on your monitor; I've seen text that shows up as clear as day on one screen look almost invisible on another.

This shade of gray was chosen because it's the same shade of gray used for line comments in the One Dark theme. I was constrained to using colors only found in the One Dark palette, and I felt that using white was much too bright and I was already using a slightly brighter shade for bolded text.

With thousands of downloads, this is the only issue with regarding text contrast so far so I think I'll keep it as is for now. However I'll keep the issue open, and if it gets a bit more support I have no issue boosting the contrast :)

In the meantime, it's always very easy to modify this yourself. Simply open up your Terminal preferences, select the One Dark profile, and change the color for "Text".

[nixpulvis]

This is the first and only part of this theme I change. The reason for this is that while comments sit at a level apart from my source code, and therefor deserve a more subdued color, plain text in a terminal is the primary tenant and should be more pronounced.

[nathanbuchar]

Thanks for the feedback. What color do you change it to, or what would you suggest that I change it to?

[nixpulvis]

I'm currently using #abb2bf which was taken from the text color of one-dark.

[thomasboyt]

Thanks for mentioning the hex code @nixpulvis; I installed this theme and had the same immediate reaction. I'm various curious what screens people are using where this is enough contrast for them; on both my Macbook Air and my UltraSharp monitor this was waaaay too low of contrast.

According to http:https://webaim.org/resources/contrastchecker/, the default foreground-on-background has a contrast ratio of 3.09:1, significantly under the recommended 4.5:1. I understand your desire for subdued text, but I think a contrast ratio so low really shouldn't ship as the default - maybe a "muted" option would be more appropriate?

(Other than this nitpick I quite like this theme, thanks @nathanbuchar 😄 )

[nathanbuchar]

Alright, I'm convinced. If someone would like to submit a PR, I will accept it

[thomasboyt]

Hi @nathanbuchar - it looks like your change in dbd53f1 may have accidentally reverted the change in #7. Was that intentional?