Fix #137, Reduce length of string_variable[] initializer string

[thnkslprpt]

Checklist

• I reviewed the Contributing Guide.
• I signed and emailed the appropriate Contributor License Agreement to [email protected] and copied [email protected].

Describe the contribution
Fixes #137
Reduced the length of the initializer-string for string_variable[] so as to avoid potential overflow due to automatic addition of the terminating null character by the compiler.

Testing performed
GitHub CI actions all passing successfully.

Expected behavior changes
No impact on code behavior.

Contributor Info
Avi Weiss @thnkslprpt

[jphickey]

Actually I don't think this one needs fixing. The C compiler allows for the string to completely fill the buffer, it just won't terminate it with a NUL char as a result. This is OK in this case because this is part of the "SendDataTypes" command and the intent here is specifically to check for corner cases in the data encodings. This intentionally has a string buffer that is 10 chars in size and it fills all 10 chars.

Any software that receives these TLM messages must decode messages properly according to the definition and should never assume that string buffers are null terminated. This test command helps check for that by intentionally sending such a message where the string is entirely full and there is no terminating char.

[thnkslprpt]

Makes sense Joe - thanks for the explanation.