Fix #131, Rename CommandCode variable to FcnCode #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thnkslprpt CCB 20 October 2022: Approved pending resolution of failed workflow (squash commits?) |
thnkslprpt
force-pushed
the
fix-131-rename-commandcode-variable
branch
from
8bde23e
to
80d5903
Compare
thnkslprpt
force-pushed
the
fix-131-rename-commandcode-variable
branch
from
80d5903
to
2d7e01c
Compare
2 tasks
|
Sorry - replaced with #171 (I still can't figure out how to deal with rebases that remove all changes, and then add back the actual changes from PR into 1 commit without closing the issue...) |
|
@thnkslprpt - cherry-pick might be what you are looking for: https://git-scm.com/docs/git-cherry-pick. Allows you to apply just the changes in a specific commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
CommandCodevariable inTO_LAB_exec_local_command()toFcnCodeto better align with the cFE API.Testing performed
Standard cFS bundle tests all passed.
Build/run cFS and test NOOP and other commands with the GroundSystem tool. All working fine.
Expected behavior changes
No impact on behavior.
Improves code clarity and consistency in the lab apps.
System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
cFE v7.0.0-rc4+dev197, OSAL v6.0.0-rc4+dev143, PSP v1.6.0-rc4+d
Sample App v1.3.0-rc4+dev35
CI Lab App v2.5.0-rc4+dev39
TO Lab v2.5.0-rc4+dev31
Contributor Info
Avi Weiss @thnkslprpt