Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ comment style and commented out code violations #246

Closed
skliper opened this issue Feb 3, 2021 · 4 comments · Fixed by #253
Closed

C++ comment style and commented out code violations #246

skliper opened this issue Feb 3, 2021 · 4 comments · Fixed by #253
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Feb 3, 2021

Is your feature request related to a problem? Please describe.
C++ comment style and commented out code violates style guidelines

//extern int rtems_shell_main_wkspace_info(int argc,char *argv[]);
//extern int rtems_shell_main_malloc_info( int argc, char *argv[]);
void CFE_PSP_MemReport(char *message)
{
//int MemStatus;
//char *malloc_argv[] = {"malloc", "info"};
//char *wkspace_argv[] = {"wkspace", "info"};
OS_printf("------------------------ Memory Stat Report ----------------------------\n");
OS_printf(" Called from: %s\n",message);
OS_printf("------------------------ Dumping Malloc Stats: ----------------------------\n");
//MemStatus = rtems_shell_main_malloc_info(2, malloc_argv);
//OS_printf("rtems_shell_main_malloc_info() rc=%d\n",(int)MemStatus);
OS_printf("------------------------ Dumping Wkspace Stats: ----------------------------\n");
//MemStatus = rtems_shell_main_wkspace_info(2, wkspace_argv);
//OS_printf("rtems_shell_main_wkspace_info() rc=%d\n",(int)MemStatus);
OS_printf("------------------------ Done ----------------- ----------------------------\n");
}

Describe the solution you'd like
Clean up

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added the enhancement New feature or request label Feb 3, 2021
@skliper skliper added this to the 1.6.0 milestone Feb 3, 2021
@skliper
Copy link
Contributor Author

skliper commented Feb 3, 2021

Need to figure out if these should be actually implemented or removed.

@zanzaben
Copy link
Contributor

The parts commented out have been that way since it was first brought over from the PSP 1.3.0.0 code base 2 years ago so I am confident it can be removed.

Also the function CFE_PSP_MemReport isn't used anywhere else in the code base so should it be removed entirely.

@zanzaben zanzaben added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Feb 23, 2021
@astrogeco astrogeco added CCB:2021-02-24 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Feb 24, 2021
@astrogeco
Copy link
Contributor

CCB:2021-02-24 APPROVED

  • Remove, probably an old debug function

@skliper
Copy link
Contributor Author

skliper commented Feb 24, 2021

CCB 20210224 - votes to remove function/file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants