Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ellipse matching issues #1

Open
aliounis opened this issue Sep 29, 2023 · 0 comments
Open

ellipse matching issues #1

aliounis opened this issue Sep 29, 2023 · 0 comments

Comments

@aliounis
Copy link
Collaborator

  • Otsu thresholding only returning n-1 thresholds instead of n thresholds (for 4-level otsu, only get 3)
    • In image_processing.py, line 784 (thresholds = unique_iu8[kk[:n - 2]].astype(np.float64)) should be thresholds = unique_iu8[kk[:n - 1]].astype(np.float64)
  • Also in otsu, kk should be sorted after being found in sig_fun
    • Between line 775 and 777 in image_processing.py, needs kk = np.sort(kk)
  • Outlier rejection does not perform correctly when body is large in frame
    • If the object is greater that ~50% of the image area, the outlier check in identify_subpixel_limbs does not function as expected
    • Starts on line 1899 in image_processing.py, commenting out lines 1899-1909 did not seem to affect any other cases, including when object was small. Should double check necessity of it
  • Potential to run out of memory when object is large in frame
    • In _pixel limbs in image_processing.py, if there are too many edge points (typically when object is large in high resolution image), the line edge_distances = np.abs(perpendicular_direction.reshape(1, 1, 2) @ scan_start2edge_points).squeeze() grabs too much memory leading the process to be killed. Seen mainly during close flybys with image sizes of 2048x2048 or larger. Could potentially do piecewise after a check? Binning image and edge pixels to lower resolution? Have not fixed this one yet, interested in hearing your thoughts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant