Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #129, Apply consistent Event ID names to common events #130

Merged

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Oct 21, 2022

Checklist

Describe the contribution

Testing performed
Only GitHub CI actions.

Expected behavior changes
No impact on code behavior (no logic changes).
Consistent Event ID names for the events which are common to all/most cFS components and apps will improve consistency and ease make code review/debugging easier.

Contributor Info
Avi Weiss @thnkslprpt

@dzbaker dzbaker self-assigned this Oct 27, 2022
@dzbaker dzbaker added this to the Fornax milestone Nov 21, 2022
@dzbaker dzbaker modified the milestones: Fornax, Equuleus Dec 7, 2022
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to get these into the next round

@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Nov 1, 2023
@thnkslprpt thnkslprpt force-pushed the fix-129-apply-consistent-event-id-names branch from 47cc323 to 50f9947 Compare November 1, 2023 17:24
@jphickey jphickey force-pushed the fix-129-apply-consistent-event-id-names branch from 50f9947 to ffb9401 Compare November 1, 2023 17:24
@thnkslprpt thnkslprpt force-pushed the fix-129-apply-consistent-event-id-names branch from ffb9401 to 60626f1 Compare November 1, 2023 17:25
@jphickey
Copy link
Contributor

jphickey commented Nov 1, 2023

I did the rebase on this one, but I think we may have done at the same time....

@thnkslprpt
Copy link
Contributor Author

thnkslprpt commented Nov 1, 2023

I did the rebase on this one, but I think we may have done at the same time....

haha woops - tried to save you the trouble...

Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased changes look correct

@jphickey
Copy link
Contributor

jphickey commented Nov 1, 2023

I did the rebase on this one, but I think we may have done at the same time....

haha woops - tried to save you the trouble...

Probably the rest of the PRs will need a rebase too, if you want to look, I'll hold off

@thnkslprpt
Copy link
Contributor Author

I did the rebase on this one, but I think we may have done at the same time....

haha woops - tried to save you the trouble...

Probably the rest of the PRs will need a rebase too, if you want to look, I'll hold off

Yes I'll go through them now mate.

@thnkslprpt
Copy link
Contributor Author

thnkslprpt commented Nov 1, 2023

Probably the rest of the PRs will need a rebase too, if you want to look, I'll hold off

@jphickey all cleared up now I think

@dzbaker dzbaker added CCB:Approved Indicates code approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Nov 2, 2023
@dmknutsen dmknutsen merged commit 6cb24be into nasa:main Nov 8, 2023
11 checks passed
@thnkslprpt thnkslprpt deleted the fix-129-apply-consistent-event-id-names branch November 9, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Event ID naming
4 participants