Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1512, Add Coding Standard Rules in CodeQL #1513

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Fix #1512, Add Coding Standard Rules in CodeQL #1513

merged 1 commit into from
Jun 2, 2021

Conversation

ArielSAdamsNASA
Copy link

@ArielSAdamsNASA ArielSAdamsNASA commented May 13, 2021

Describe the contribution
Fix #1512
Added the duplicate jobs action to avoid duplicate jobs from running. Added a separate job for coding standard queries. Created two configuration files, one for default queries and security queries and another for jpl rules.

Testing performed
Testing done on forked repository, ArielSAdamsNASA/cFE. https://github.com/ArielSAdamsNASA/cFE/actions/runs/861283509/workflow

Jobs were failing when the entire path of the configuration file were not used. Have to use nasa/cFE/.github/codeql/config-name@branch-name. The branch must be included in the path.

The CodeQL analysis workflow will fail for this PR since it is calling for a configuration file in main the main branch. It will not work until the configuration files are merged into main.

In the screenshot is the same workflow as in this pull request, but the configuration path is changed to the forked repo and tested branch.

image

Expected behavior changes
There should be one job for security queries and one job for JPL and MISRA queries.

Third party code
Skip duplicate workflows license: https://github.com/fkirc/skip-duplicate-actions/blob/master/LICENSE

CodeQL license: https://github.com/github/codeql-action/blob/main/LICENSE

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal

@ArielSAdamsNASA ArielSAdamsNASA marked this pull request as draft May 13, 2021 17:19
@ArielSAdamsNASA ArielSAdamsNASA marked this pull request as ready for review May 20, 2021 17:48
@ArielSAdamsNASA ArielSAdamsNASA deleted the fix-1512-coding-standard-codeql branch May 20, 2021 18:40
@skliper
Copy link
Contributor

skliper commented May 20, 2021

@ArielSAdamsNASA Could you include a link to the duplicate for traceability?

EDIT - obsolete comment, PR was reopened

@ArielSAdamsNASA ArielSAdamsNASA added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 21, 2021
@skliper
Copy link
Contributor

skliper commented May 26, 2021

CCB: Approved, consider moving configuration to cFS

@skliper skliper added the CCB:Approved Indicates code review and approval by community CCB label May 26, 2021
@ArielSAdamsNASA
Copy link
Author

Removed configuration files and used cFS configuration files instead. CodeQL workflow is successful.

@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 27, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate June 2, 2021 15:11
@astrogeco astrogeco merged commit 41d552c into nasa:integration-candidate Jun 2, 2021
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB continuous-integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement JPL Rules in CodeQL
4 participants