Fix #42, naming conventions and style compliance #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
force-pushed
the
fix-42-naming-conventions
branch
2 times, most recently
from
30464ce
to
300e7ce
Compare
jphickey
added
the
CCB:Ready
|
Preemptively marked as ready, this just needs a fresh baseline but can be initially reviewed. Real change starts from b55cf70 |
jphickey
force-pushed
the
fix-42-naming-conventions
branch
from
300e7ce
to
b42f0f5
Compare
astrogeco
removed
the
CCB:Ready
|
CCB:2021-12-08 - APPROVED
|
Updates names of all identifiers declared in cf_cfdp_pdu.h to adhere to naming conventions. This also updates documentation on many of the items in cf_cfdp_pdu.h
Updates names of all identifiers in cf_cfdp.h to follow naming conventions from CFE.
Updates names of all identifiers in cf_chunk.h to follow naming conventions from CFE.
Update names of all identifiers in cf_clist.h to follow naming conventions from CFE.
Updates names of all identifiers in cf_crc.h to follow naming conventions from CFE.
Updates names of all identifiers in cf_msg.h to follow naming conventions from CFE.
Updates names of all identifiers in cf_timer.h and cf_utils.h to follow naming conventions from CFE.
…fy.h Updates names of all identifiers in cf_version.h and cf_verify.h to follow naming conventions from CFE. This only affects include guards
Updates names of all identifiers in platform_inc to follow naming conventions from CFE.
jphickey
force-pushed
the
fix-42-naming-conventions
branch
from
b42f0f5
to
6bde5e5
Compare
|
This has been rebased to "main" now that all the dependencies are satisfied. Should be OK to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update identifier names across CF source code to match the CFS naming convention. This convention is documented in the CFE framework, see https://github.com/nasa/cFE/blob/main/docs/cFS_IdentifierNamingConvention.md
Changes are mostly just search/replace. Each file will be done separately, to keep the commit size within reason. But these will not likely be easy to merge/split due to the number of lines affected so they need to be maintained as a series.
Fixes #42