Fix #44, #46, instantiate properly sized and aligned buffers #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For unit unit tests that invoke CF PDU processing functions on either input or output, ensure that the locally instantiated "dummy" PDU is both sized sufficiently and aligned correctly. This removes quite a bit of questionable casting between the buffer types, and fixes a number of stack-smashing issues. For completeness, this also clears (memset to 0) all instantiated buffers, before setting values in the test. This ensures that the entire message structure has predictable/repeatable content.
jphickey
added
the
CCB:Ready
astrogeco
removed
the
CCB:Ready
|
CCB:2021-12-08 - APPROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For unit unit tests that invoke CF PDU processing functions on either input or output, ensure that the locally instantiated
"dummy" PDU is both sized sufficiently and aligned correctly.
This removes quite a bit of questionable casting between the buffer types, and fixes a number of stack-smashing issues.
For completeness, this also clears (memset to 0) all instantiated buffers, before setting values in the test. This ensures that the
entire message structure has predictable/repeatable content.
Fixes #44
Fixes #46