Fix #157, adjust padding in msg structs #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explicit spare bytes where the compiler is likely to introduce padding into hte message structures. CFS SB messages should avoid having any implicit padding, whenever possible.
skliper
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Add explicit spare bytes where the compiler is likely to introduce padding into hte message structures. CFS SB messages should avoid having any implicit padding, whenever possible.
Fixes #157
Testing performed
Build and run tests, send some commands to sanity check
Expected behavior changes
None really, the padding was implicitly in the messages already, this just makes it clear/explicit.
System(s) tested on
Ubuntu 21.04 (on 64-bit CPU)
Additional context
This probably needs COSMOS updates as well (TBD)
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.