Fix #32, compile out CF_Asserts by default #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes CF_Assert to be opt-in rather than opt-out, so that under normal verification and validation the asserts will _not_ be included, but they can still be added back during development, if desired. They mainly exist as notes to developers as to what is supposed to be true, once debugged it is impossible to get these conditions, by definition. Also removes one channel calculation that was only for assert. Note that the same condition is asserted later, so it was redundant anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Changes CF_Assert to be opt-in rather than opt-out, so that under normal verification and validation the asserts will not be included, but they can still be added back during development, if desired.
They mainly exist as notes to developers as to what is supposed to be true, once debugged it is impossible to get these conditions, by definition.
Also removes one channel calculation that was only for assert. Note that the same condition is asserted later, so it was redundant anyway.
Fixes #32
Testing performed
Build and sanity check CF with CF_DEBUG_BUILD set both ways
Expected behavior changes
Branch coverage on LCOV report is much better with asserts compiled out.
System(s) tested on
Ubuntu 21.10
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.